Fix: Require Send on closures connected to signals #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 11928 11928
=========================================
Hits 11928 11928 ☔ View full report in Codecov by Sentry. |
The closures may be executed on a different thread, depending on where the emitting object lives. Also closes KDAB#577. We have determined that is indeed safe to queue a deferred closure, as the closure will not be called if the object is deleted, as we use the object itself as the context.
ahayzen-kdab
force-pushed
the
577-connection-traits
branch
from
3a2dcda
to
9d0d9a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The closures may be executed on a different thread, depending on where
the emitting object lives.
Also closes #577. We have determined that is indeed safe to queue a
deferred closure, as the closure will not be called if the object is
deleted, as we use the object itself as the context.